trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1474: fix [trafodion-2988] prepare query returns 200...
Date Wed, 14 Mar 2018 22:00:32 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1474#discussion_r174623263
  
    --- Diff: core/sql/optimizer/mdam.cpp ---
    @@ -2002,7 +2002,8 @@ void Disjuncts::computeCommonPredicates()
     	      inVidset.next(predId);
     	      inVidset.advance(predId) )
     	 {
    -            if(predId.getItemExpr()->getOperatorType() == ITM_RANGE_SPEC_FUNC )
    +            //TRAFODION-2988
    +            /*if(predId.getItemExpr()->getOperatorType() == ITM_RANGE_SPEC_FUNC )
    --- End diff --
    
    One cosmetic issue. It is better to delete code you are replacing rather than commenting
it out. The only reason to comment out code is if we are temporarily disabling it in hopes
of putting it back it later.


---

Mime
View raw message