trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1487: [TRAFODION-3003]Trafodion keepalive support
Date Thu, 22 Mar 2018 16:11:36 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1487#discussion_r176478042
  
    --- Diff: core/conn/odbc/src/odbc/Common/Global.h ---
    @@ -935,7 +941,10 @@ typedef struct _SRVR_GLOBAL_Def
     		bzero(m_ProcName,sizeof(m_ProcName));
     		m_bNewConnection = false;
     		m_bNewService = false;
    -
    +        bzero(clientKeepaliveStatus, sizeof(clientKeepaliveStatus));
    --- End diff --
    
    Minor point: If we could keep the indentation consistent, that will make the code easier
to read in the future. (Perhaps the new code uses tabs and the old code doesn't? Or maybe
the old code uses tabs but the new code doesn't? In the past, we've tried to avoid tabs because
they lead to these kinds of problems but we have not been successful in keeping them out.)


---

Mime
View raw message