trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1492: [TRAFODION-3007] update statistics report erro...
Date Thu, 22 Mar 2018 20:34:49 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1492#discussion_r176563291
  
    --- Diff: core/sql/ustat/hs_parser.cpp ---
    @@ -243,13 +243,6 @@ Lng32 AddTableName( const hs_table_type type
               }
             else 
               {
    -            // This is for UPDATE STATISTICS; the volatile schema name exists.
    -            // For now, UPDATE STATISTICS is not supported. (See also JIRA Trafodion-2004.)
    -
    -            HSFuncMergeDiags(-UERR_VOLATILE_TABLES_NOT_SUPPORTED);
    -            retcode = -1;
    -            HSHandleError(retcode); // causes a return from this function
    -
                 // The code below is old code that will be needed once we turn on
                 // support for UPDATE STATISTICS on volatile tables. We leave it here
    --- End diff --
    
    We could delete the comments "The code below is old code..." since we are turning support
back on.


---

Mime
View raw message