trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1493: [TRAFODION-2821] Trafodion core code base need...
Date Thu, 22 Mar 2018 20:48:25 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1493#discussion_r176566585
  
    --- Diff: core/sql/executor/HBaseClient_JNI.cpp ---
    @@ -434,10 +429,7 @@ HBC_RetCode HBaseClient_JNI::releaseHTableClient(HTableClient_JNI*
htc)
           tsRecentJMFromJNI = JavaMethods_[JM_REL_HTC].jm_full_name;
           jenv_->CallVoidMethod(javaObj_, JavaMethods_[JM_REL_HTC].methodID, j_htc);
           if (jenv_->ExceptionCheck()) {
    -         getExceptionDetails();
    -         logError(CAT_SQL_HBASE, __FILE__, __LINE__);
    -         logError(CAT_SQL_HBASE, "HBaseClient_JNI::releaseHTableClient()", getLastError());
    -         jenv_->PopLocalFrame(NULL);
    --- End diff --
    
    Did you mean to delete the jenv_->PopLocalFrame call here?


---

Mime
View raw message