trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hegdean <...@git.apache.org>
Subject [GitHub] trafodion pull request #1499: [TRAFODION-3003]Trafodion keepalive support
Date Tue, 27 Mar 2018 18:32:45 GMT
Github user hegdean commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1499#discussion_r177527743
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvr/Interface/Listener_srvr.cpp ---
    @@ -81,4 +81,49 @@ void CNSKListenerSrvr::TCP_PROCESSNAME_PORT(FILE* fp)
     	fprintf(fp,"<==========TCP/PORT (%s/%d)==========>\n",m_TcpProcessName, m_port);
     }
     
    +void CNSKListenerSrvr::TCP_SetKeepalive(int socketnum,
    +                                        char *keepaliveStatus,
    +                                        int idleTime,
    +                                        int intervalTime,
    +                                        int retryCount)
    +{
    +    //all need to be configured
    +    if(NULL == keepaliveStatus){
    +        return;
    +    }
    +    if(0 == strcmp(keepaliveStatus,"default")){
    --- End diff --
    
    Can the status be boolean (TRUE or FALSE)  and default value can be set FALSE


---

Mime
View raw message