trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CoderSong2015 <...@git.apache.org>
Subject [GitHub] trafodion pull request #1499: [TRAFODION-3003]Trafodion keepalive support
Date Thu, 29 Mar 2018 06:35:04 GMT
Github user CoderSong2015 commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1499#discussion_r177963928
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvr/Interface/linux/Listener_srvr_ps.cpp ---
    @@ -263,7 +263,11 @@ void* CNSKListenerSrvr::OpenTCPIPSession()
     //LCOV_EXCL_STOP
     	}
     
    -
    +    TCP_SetKeepalive(nSocketFnum,
    --- End diff --
    
    I think you are right, but I have seen the same name style in mxosrvr a lot of times,
like in SrvrConnect.cpp and odbcas_drvr.cpp. So I think they are all allowed here.


---

Mime
View raw message