trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1473: [TRAFODION-2977] Fix issues with maximum key l...
Date Tue, 13 Mar 2018 20:04:47 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/trafodion/pull/1473

    [TRAFODION-2977] Fix issues with maximum key length detection

    This set of changes fixes several minor bugs:
    
    1. The key length limit that Trafodion imposes differed from the HBase limit. They are
now the same.
    
    2. CREATE INDEX logic lacked a check on key length. This has now been added.
    
    3. There was a typo in the message text for message 1141 preventing the computed key length
from being displayed. This has been fixed.
    
    4. There was a bug in the generator where, if CREATE INDEX were allowed to have a long
key, we generated plans to populate that index that would overrun their buffers, causing ESPs
to core. This has been fixed; we now guarantee that buffers are long enough for at least one
row.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/trafodion Trafodion2977

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1473.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1473
    
----
commit e7fd657474842b017e26f50aeda3895b7cfd337c
Author: Dave Birdsall <dbirdsall@...>
Date:   2018-03-13T20:00:18Z

    [TRAFODION-2977] Fix issues with maximum key length detection

----


---

Mime
View raw message