trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1578: [TRAFODION-3070] we cannot comment on native h...
Date Thu, 24 May 2018 16:11:13 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1578#discussion_r190645661
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp ---
    @@ -229,6 +229,16 @@ void  CmpSeabaseDDL::doSeabaseCommentOn(StmtDDLCommentOn   *commentOnNode,
       enum ComObjectType enMDObjType = COM_UNKNOWN_OBJECT;
     
       ComObjectName objectName(commentOnNode->getObjectName());
    +  //we can not comment on native hive table.
    +  if (str_cmp(toUpper(currCatName.data()), "HIVE", 4) == 0)
    --- End diff --
    
    Please use the literal HIVE_SYSTEM_CATALOG (see common/ComSmallDefs.h) instead of hard-coding
"HIVE".


---

Mime
View raw message