trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xiaozhongwang <...@git.apache.org>
Subject [GitHub] trafodion pull request #1534: [TRAFODION-3039] SendEventMsg is used in a wro...
Date Tue, 29 May 2018 01:14:52 GMT
Github user xiaozhongwang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1534#discussion_r186468687
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
    @@ -6533,6 +6533,8 @@ odbc_SQLSrvr_ExtractLob_sme_(
             if (retcode == SQL_ERROR)
             {
                 ERROR_DESC_def *p_buffer = QryLobExtractSrvrStmt->sqlError.errorList._buffer;
    +            char             errNumStr[128];
    +            sprintf(errNumStr, "%d", p_buffer->sqlcode);
                 strncpy(RequestError, p_buffer->errorText, sizeof(RequestError) - 1);
    --- End diff --
    
    I don't understand you question, do you think RequestError is too small?
    Here used strncpy, the error message may be cut, I don't think it can cause core dump.


---

Mime
View raw message