trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1645: [TRAFODION-3144] Correct Syntactic Description...
Date Wed, 18 Jul 2018 22:51:45 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1645#discussion_r203555402
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
    @@ -390,25 +390,27 @@ alter-action is:
     
     column-definition is:
        column-name data-type
    -      ([DEFAULT default]
    -         [[constraint constraint-name] column-constraint])
    +      [[DEFAULT default]
    +         [[constraint constraint-name] column-constraint]]
     
     data-type is:
    -     char[acter] [(length)[characters]]
    -         [CHARACTER SET char-set-name]
    -         [UPSHIFT] [[not] casespecific]
    -   | char[acter] varying (length)
    -         [character set char-set-name]
    -         [upshift] [[not] casespecific]
    -   | varchar (length) [character set char-set-name]
    -         [upshift] [[not] casespecific]
    -   | varchar2 (length) [character set char-set-name]
    -         [upshift] [[not] casespecific]         
    +     char[acter] [(length) [characters]]
    --- End diff --
    
    Should be "char[acter] [(length [characters])]". The optional [characters] syntactic element
should be inside the parenthesis.


---

Mime
View raw message