trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zlei929 <...@git.apache.org>
Subject [GitHub] trafodion pull request #1658: [TRAFODION-3155] implemented the OVERLAPS pred...
Date Wed, 25 Jul 2018 05:29:28 GMT
Github user zlei929 commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1658#discussion_r204984946
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -19430,6 +19432,124 @@ exists_predicate : TOK_EXISTS rel_subquery
     				  $$ = new (PARSERHEAP()) Exists($2);
     				}
     
    +overlaps_predicate : value_expression_list_paren TOK_OVERLAPS value_expression_list_paren
    +         {
    +            ItemExprList  exprList1($1, PARSERHEAP());
    +            ItemExprList  exprList2($3, PARSERHEAP());
    +            //Syntax Rules: 
    +            //  1) The degrees of <row value predicand 1> and <row value predicand
2> shall both be 2.
    +            if ((exprList1.entries() != 2)
    +                  || (exprList1.entries() != exprList2.entries()))
    +              {
    +                 *SqlParser_Diags << DgSqlCode(-4077)
    +                     << DgString0("OVERLAPS");
    +                 YYERROR;  // CHANGE TO YYABORT
    +              }
    +
    +            ItemExpr *D1 = (*$1)[0];
    +            ItemExpr *E1 = (*$1)[1];
    +            ItemExpr *D2 = (*$3)[0];
    +            ItemExpr *E2 = (*$3)[1];
    +
    +            NABoolean negate = FALSE;
    +            ItemExpr *tmpItemExpr = E1;
    --- End diff --
    
    Yes, @DaveBirdsall,  Thanks for your reminding, i will changed this.


---

Mime
View raw message