trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zlei929 <...@git.apache.org>
Subject [GitHub] trafodion pull request #1654: [TRAFODION-3136] Bug fixed: If position is a n...
Date Fri, 20 Jul 2018 05:15:09 GMT
GitHub user zlei929 opened a pull request:

    https://github.com/apache/trafodion/pull/1654

    [TRAFODION-3136] Bug fixed:  If position is a negative value, the result does not match
expectations.

    **Before this, the result of below SQL are incorrect:**
    >> select split_part('aaabbcc', 'bb', -2) from dual;
    
    (EXPR)
    ------
    
          
    
    --- 1 row(s) selected.   (error)
    
    **for now,** 
    
    >> select split_part('aaabbcc', 'bb', -2) from dual;
    
    *** ERROR[8691] Field position must be greater than zero, currently is -2.
    
    --- 0 row(s) selected. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zlei929/trafodion TRAFODION-3136

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1654.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1654
    
----
commit 153368d2d1e1f6f5e279ded0e6d4902bba43a498
Author: zlei929 <z_lei929@...>
Date:   2018-07-20T04:18:28Z

     	modified:   ../generator/GenPreCode.cpp
     	modified:   ../optimizer/ItemFunc.h

commit b054192046526e9569214f9305ba98d27595358d
Author: zlei929 <z_lei929@...>
Date:   2018-07-20T05:10:30Z

     	modified:   core/sql/regress/core/EXPECTED038.LINUX
     	modified:   core/sql/regress/core/TEST038

----


---

Mime
View raw message