trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1718: [TRAFODION-3214] ODBC error message is truncat...
Date Wed, 26 Sep 2018 20:00:40 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1718#discussion_r220703185
  
    --- Diff: win-odbc64/odbcclient/drvr35/cdiag.cpp ---
    @@ -378,15 +378,15 @@ SQLRETURN CDiagRec::GetDiagRec(SQLSMALLINT	RecNumber,
     
     		//Double strLen to circumvent the bug in driver manager, that requires us to give 
     		//the NO. OF BYTES instead of no. of characters
    -		strLen = tmpStrLen * 2;
    +		strLen = tmpStrLen;
    --- End diff --
    
    Should the comment before this statement be deleted?


---

Mime
View raw message