trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wenjun-zhu <...@git.apache.org>
Subject [GitHub] trafodion pull request #1722: [trafodion-3211]refactor the usage of setDiags...
Date Sat, 29 Sep 2018 12:19:15 GMT
GitHub user wenjun-zhu opened a pull request:

    https://github.com/apache/trafodion/pull/1722

    [trafodion-3211]refactor the usage of setDiagsArea()

    Two points:
    - append a letter `x` to the function name setDiagsArea()
    - add a new function shareDiagsArea(), which increase the refCount of the source ComDiagsArea.
    
    This PR serves as a code base for further discussion. And the appendix letter `x` would
be removed before merging.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wenjun-zhu/trafodion jira-3211-setDiagsArea

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1722.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1722
    
----
commit 641bcde2ff2ece4bbc1ccca9b7452ec0d55312d8
Author: wenjun.zhu <wenjun.zhu@...>
Date:   2018-09-29T12:11:36Z

    refactor the usage of setDiagsArea()

----


---

Mime
View raw message