trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...
Date Tue, 02 Oct 2018 04:55:24 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1688#discussion_r221824983
  
    --- Diff: core/sql/executor/ExExeUtil.h ---
    @@ -4172,6 +4173,48 @@ class ExExeUtilLobInfoPrivateState : public ex_tcb_private_state
     protected:
     };
     
    +class connectByStackItem
    --- End diff --
    
    I think it is unusual in the executor to have classes that do not have a base class. How
about memory management for this class. I might understand more as I see how these classes
are used.


---

Mime
View raw message