trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...
Date Tue, 02 Oct 2018 04:55:24 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1688#discussion_r221820929
  
    --- Diff: core/sql/optimizer/ValueDesc.cpp ---
    @@ -4555,7 +4555,7 @@ void ValueIdSet::unparse(NAString &result,
     
       NAString connectorText;
     
    -  if ((form == MVINFO_FORMAT) || (form == QUERY_FORMAT))
    +  if ((form == MVINFO_FORMAT) || (form == QUERY_FORMAT) || (form == CONNECT_BY_FORMAT))
    --- End diff --
    
    How is the CONNECT_BY_FORMAT different from QUERY or MVINFO formats? The answer might
be in other parts of code, its just that I cannot tell. Thank you for explaining


---

Mime
View raw message