trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] trafodion pull request #1688: [TRAFODION-3034] Support Oracle Hierarchy Quer...
Date Tue, 02 Oct 2018 04:55:24 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1688#discussion_r221819571
  
    --- Diff: core/sql/optimizer/SynthType.cpp ---
    @@ -7291,3 +7291,11 @@ const NAType * SplitPart::synthesizeType()
                                  );
     
     }
    +
    +const NAType * ItmSysConnectByPathFunc::synthesizeType()
    +{
    +    NAType * type;
    +    type = new HEAP
    +      SQLVarChar(HEAP, 3000, FALSE);
    --- End diff --
    
    The value 3000 seems arbitrary. It is not related to the column used in CONNECT_BY_PATH,
nor to the depth of recursion. Consider making this settable by cqd. If that is not necessary,
maybe a constant can be used to improve readability.


---

Mime
View raw message