trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...
Date Sun, 14 Oct 2018 23:52:42 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r225014789
  
    --- Diff: core/sql/executor/ExUdr.cpp ---
    @@ -792,9 +796,57 @@ Int32 ExUdrTcb::fixup()
                          this, udrServer_->getUdrControlConnection());
             }
           }
    -
    +      
    +      NAString cachedLibName, cachedLibPath;
    +      if ((myTdb().getLibraryRedefTime() != -1) && (myTdb().getLibraryRedefTime()
!= 0))
    +        {
    +          // Cache library locally. 
    +          NAString dummyUser;
    +          NAString libOrJarName;
    +        
    +          if (myTdb().getLanguage() == COM_LANGUAGE_JAVA)
    +            libOrJarName = myTdb().getPathName();
    +          else
    +            libOrJarName = myTdb().getContainerName();
    --- End diff --
    
    Are there any special considerations for SPSQL jars?


---

Mime
View raw message