trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...
Date Sun, 14 Oct 2018 23:52:42 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r225014825
  
    --- Diff: core/sql/generator/Generator.cpp ---
    @@ -2352,6 +2352,14 @@ TrafDesc *Generator::createVirtualRoutineDesc(
        strcpy(routine_desc->routineDesc()->signature, routineInfo->signature);
        routine_desc->routineDesc()->librarySqlName = new GENHEAP(space) char[strlen(routineInfo->library_sqlname)+1];
        strcpy(routine_desc->routineDesc()->librarySqlName, routineInfo->library_sqlname);
    +   routine_desc->routineDesc()->libRedefTime = routineInfo->lib_redef_time;
    +   routine_desc->routineDesc()->libBlobHandle = routineInfo->lib_blob_handle;
    +
    +   routine_desc->routineDesc()->libVersion = routineInfo->library_version;
    +   routine_desc->routineDesc()->libObjUID = routineInfo->lib_obj_uid;
    +   //routine_desc->routineDesc()->libSchName = new GENHEAP(space) char[strlen(routineInfo->lib_sch_name)+1];
    +   //strcpy(routine_desc->routineDesc()->libSchName ,routineInfo->lib_sch_name);
    +   routine_desc->routineDesc()->libSchName = routineInfo->lib_sch_name;
    --- End diff --
    
    Remove comments?  Do you need a deep copy for lib_sch_name?


---

Mime
View raw message