trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...
Date Sun, 14 Oct 2018 23:52:47 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r225015093
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLupgrade.cpp ---
    @@ -314,7 +326,7 @@ short CmpSeabaseMDupgrade::executeSeabaseMDupgrade(CmpDDLwithStatusInfo
*mdui,
       // now as they are stateless
       CmpSeabaseUpgradeRepository upgradeRepository;
       CmpSeabaseUpgradePrivMgr upgradePrivMgr;
    -
    +  CmpSeabaseUpgradeLibraries upgradeLibraries;
    --- End diff --
    
    Since we create repository, libraries, and then privmgr, perhaps upgradeLibraries should
come before upgradePrivMgr?


---

Mime
View raw message