trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...
Date Sun, 14 Oct 2018 23:52:47 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r225015111
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLupgrade.cpp ---
    @@ -1657,7 +1717,7 @@ short CmpSeabaseMDupgrade::executeSeabaseMDupgrade(CmpDDLwithStatusInfo
*mdui,
     		    {
     		      *CmpCommon::diags() << DgSqlCode(-20123);
     
    -		      mdui->setStep(UPGRADE_FAILED_RESTORE_OLD_REPOS);
    +		      mdui->setStep(UPGRADE_FAILED_RESTORE_OLD_LIBRARIES);
    --- End diff --
    
    We have already completed the upgrade library step, should this step (and others that
follow) indicate we were in the update version step?  In a subsequent release, we may not
be upgrading libraries but something else. 


---

Mime
View raw message