trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1747: [TRAFODION-3235] add div and trim function for...
Date Mon, 19 Nov 2018 17:47:03 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1747#discussion_r234715228
  
    --- Diff: core/conn/odb/src/odb.c ---
    @@ -6246,7 +6248,8 @@ static void Oload(int eid)
                  trt[16];           /* translit to array */         
             char op;                /* 1=substr, 2=dconv, 3=tconv, 4=tsconv, 5=replace,
                                        6=toupper, 7=tolower, 8=firstup, 9=csubstr, 10=translit,
    -                                   11=comp, 12=comp3, 13=zoned, 14=emptyasconst, 15=emptyasempty
*/
    +                                   11=comp, 12=comp3, 13=zoned, 14=emptyasconst, 15=emptyasempty,
    +                                   16=div */
    --- End diff --
    
    Should the comments also include 17=trim?


---

Mime
View raw message