trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1746: [TRAFODION-3234] Add support for hive partitio...
Date Tue, 20 Nov 2018 23:57:13 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1746#discussion_r235211551
  
    --- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
    @@ -2355,10 +2355,134 @@ short CmpDescribeHiveTable (
           NAString colString(buf);
           Int32 j = i;
           outputColumnLine(space, colString, j);
    -    }
    +  }
     
       outputShortLine(space, "  )");
     
    +  // show hive table partitions and buckets defination.
    +  // this default schema name is what the Hive default schema is called in SeaHive
    +  HiveMetaData* md = bindWA.getSchemaDB()->getNATableDB()->getHiveMetaDB();
    +  NAString defSchema = ActiveSchemaDB()->getDefaults().getValue(HIVE_DEFAULT_SCHEMA);
    +  defSchema.toUpper();
    +  struct hive_tbl_desc* htbl;
    --- End diff --
    
    This variable doesn't seem to be used anywhere. Can we delete it?


---

Mime
View raw message