trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zhenxingh commented on a change in pull request #1786: [TRAFODION-3260] SSMP may wait 3 seconds before handling requests
Date Sat, 02 Feb 2019 01:16:48 GMT
zhenxingh commented on a change in pull request #1786: [TRAFODION-3260] SSMP may wait 3 seconds
before handling requests
URL: https://github.com/apache/trafodion/pull/1786#discussion_r253245559
 
 

 ##########
 File path: core/sql/bin/ex_ssmp_main.cpp
 ##########
 @@ -246,8 +247,12 @@ void runServer(Int32 argc, char **argv)
     }
   }
 */
-    // wait for system messages only until ssmp starts receiving msgs.
-    cc->wait(300);
+    // Wait for messages, but we need ssmp to wake up periodically to
+    // perform garbage collection.
+    short mask = XWAIT(LREQ | LDONE, ssmpGlobals->getStatsMergeTimeout());
+    if (mask & LREQ) {
+      cc->wait(0);
 
 Review comment:
   It's OK to merge the PR as is now, we can do the encapsulation later, we may also need
to do some refactoring and cleanup of the code, which may be risky and need more QA testing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message