trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] DaveBirdsall opened a new pull request #1794: [TRAFODION-3273] Avoid going off the end of wide output descriptor
Date Mon, 11 Feb 2019 20:55:30 GMT
DaveBirdsall opened a new pull request #1794: [TRAFODION-3273] Avoid going off the end of wide
output descriptor
URL: https://github.com/apache/trafodion/pull/1794
 
 
   Method InputOutputExpr::outputValues (cli/CliExpChange.cpp) has code to check that the
size of the output descriptor is the same as the number of columns returned by the statement.
It generates an 8893 error if they differ.
   
   This check is currently bypassed for "wide" descriptors. "Wide" descriptors are used for
CALL statements. On a CALL statement there may be a mix of IN, OUT and INOUT parameters. This
exposes a bug: It is possible that the output descriptor is not wide enough for the statement
output columns; in that case, we read off the end of the output descriptor.
   
   This check-in adds a check to make sure we don't go off the end of the output descriptor.
If we do, an 8892 error will be issued.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message