trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [trafodion] DaveBirdsall commented on a change in pull request #1821: [TRAFODION-3291] Fix core when multi-column stats are done on lots of columns
Date Wed, 03 Apr 2019 19:08:58 GMT
DaveBirdsall commented on a change in pull request #1821: [TRAFODION-3291] Fix core when multi-column
stats are done on lots of columns
URL: https://github.com/apache/trafodion/pull/1821#discussion_r271890028
 
 

 ##########
 File path: core/sql/ustat/hs_globals.cpp
 ##########
 @@ -994,7 +994,8 @@ void HSGlobalsClass::formGroupSets()
       {
          if (LM->LogNeeded())
          {
-            sprintf(LM->msg, "\tMC: GROUP (%s) has state DONT_TRY, is skipped", mgroup_set->colNames->data());
+            sprintf(LM->msg, "\tMC: GROUP (%s) has state DONT_TRY, is skipped", 
+              LM->truncate(mgroup_set->colNames->data(),sizeof(LM->msg-200)));
 
 Review comment:
   Actually, let me think about the HSLogMan refactoring. I could provide new methods alongside
the old, and then convert only the problem code paths to use the new methods. I will consider
that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message