tuscany-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jsdelf...@apache.org
Subject svn commit: r561431 - in /incubator/tuscany/java/sca/modules: distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/ extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ host-embedded/src/main/java/org/apache/tuscany/sca/hos...
Date Tue, 31 Jul 2007 18:38:21 GMT
Author: jsdelfino
Date: Tue Jul 31 11:38:20 2007
New Revision: 561431

URL: http://svn.apache.org/viewvc?view=rev&rev=561431
Log:
Added FIXME comments to the few instances that add to the extension point registry things
that are not extension points at all.

Modified:
    incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
    incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
    incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntimeBuilder.java

Modified: incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java?view=diff&rev=561431&r1=561430&r2=561431
==============================================================================
--- incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
(original)
+++ incubator/tuscany/java/sca/modules/distributed/src/main/java/org/apache/tuscany/sca/distributed/host/impl/DistributedRuntime.java
Tue Jul 31 11:38:20 2007
@@ -86,6 +86,7 @@
         registry = new DefaultExtensionPointRegistry();
         
         // Add the current domain to the extension point registry
+        //FIXME Pass the domain around differently as it's not an extension point
         if (domain != null ){
             registry.addExtensionPoint(domain);
         }
@@ -127,6 +128,7 @@
         scopeRegistry = ReallySmallRuntimeBuilder.createScopeRegistry(registry);
         
         // Create a work scheduler
+        //FIXME Pass this around differently as it's not an extension point
         WorkScheduler workScheduler = new Jsr237WorkScheduler(workManager);
         registry.addExtensionPoint(workScheduler);
 

Modified: incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java?view=diff&rev=561431&r1=561430&r2=561431
==============================================================================
--- incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
(original)
+++ incubator/tuscany/java/sca/modules/extension-helper/src/main/java/org/apache/tuscany/sca/spi/impl/ImplementationsActivator.java
Tue Jul 31 11:38:20 2007
@@ -57,6 +57,8 @@
         DataBindingExtensionPoint dataBindings = registry.getExtensionPoint(DataBindingExtensionPoint.class);
         TransformerExtensionPoint transformers = registry.getExtensionPoint(TransformerExtensionPoint.class);

         MediatorImpl mediator = new MediatorImpl(dataBindings, transformers);
+        
+        //FIXME Pass this factory differently as it's not an extension point
         PropertyValueObjectFactory propertyFactory = new DefaultPropertyValueObjectFactory(mediator);
         registry.addExtensionPoint(propertyFactory);
 

Modified: incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntimeBuilder.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntimeBuilder.java?view=diff&rev=561431&r1=561430&r2=561431
==============================================================================
--- incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntimeBuilder.java
(original)
+++ incubator/tuscany/java/sca/modules/host-embedded/src/main/java/org/apache/tuscany/sca/host/embedded/impl/ReallySmallRuntimeBuilder.java
Tue Jul 31 11:38:20 2007
@@ -115,7 +115,7 @@
         // Create a proxy factory
         ProxyFactory proxyFactory = new JDKProxyService(messageFactory, mapper);
 
-        // FIXME remove this
+        // FIXME Pass these around differently as they are not extension points
         registry.addExtensionPoint(proxyFactory);
         registry.addExtensionPoint(mapper);
 
@@ -130,6 +130,7 @@
                                                               WorkManager workManager) {
 
         // Create a work scheduler
+        //FIXME Pass the work scheduler differently as it's not an extension point
         WorkScheduler workScheduler = new Jsr237WorkScheduler(workManager);
         registry.addExtensionPoint(workScheduler);
 
@@ -213,7 +214,7 @@
 
         PackageProcessor packageProcessor = new ExtensiblePackageProcessor(packageProcessors,
describer);
 
-        //Create Contribution Model Resolver extension point
+        // Create Contribution Model Resolver extension point
         ModelResolverExtensionPoint modelResolverExtensionPoint = new DefaultModelResolverExtensionPoint();
         registry.addExtensionPoint(modelResolverExtensionPoint);
         
@@ -260,6 +261,7 @@
             scopeRegistry.register(f);
         }
 
+        //FIXME Pass the scope container differently as it's not an extension point
         registry.addExtensionPoint(scopeRegistry);
 
         return scopeRegistry;



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org


Mime
View raw message