uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marshall Schor (Jira)" <...@uima.apache.org>
Subject [jira] [Commented] (UIMA-6187) Bad line endings for all files UIMA_HOME/bin/*.sh
Date Thu, 06 Feb 2020 22:13:00 GMT

    [ https://issues.apache.org/jira/browse/UIMA-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031989#comment-17031989
] 

Marshall Schor commented on UIMA-6187:
--------------------------------------

Using this, it shows the src/main/scripts bat/cmd files have CRLF in the repo, and the .sh
have just LF.  The issue is the .gitattributes is defaulting converting the .sh files on
checkout to CRLF.  When the checked-out files are used in a ZIP or TAR assembly, they're
put in with CRLF, which, when unzipped, ends up with the wrong line-endings. 

In svn, the .sh files had the svn.eof-style property set to LF, this got dropped when moving
to GIT.

Fix: add to .gitattributes at the bottom (so it overrides) the line:
{code:java}
# These files cannot have crlf, must have just lf
# The "text" by itself says these files must be line-ending-conversion controlled on check-in
/ out
#   The internal repo form for these is always lf, 
#   The eol=lf means on check-out do nothing, and on check-in, if the file has crlf, convert
to lf 
*.sh text eol=lf{code}
 

> Bad line endings for all files UIMA_HOME/bin/*.sh 
> --------------------------------------------------
>
>                 Key: UIMA-6187
>                 URL: https://issues.apache.org/jira/browse/UIMA-6187
>             Project: UIMA
>          Issue Type: Bug
>          Components: Core Java Framework
>    Affects Versions: 3.1.1SDK
>            Reporter: Edward Epstein
>            Priority: Major
>
> All text files in this SDK have CRLF line endings. Linux executable scripts (bin/*.sh)
should not have them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message