usergrid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From g...@apache.org
Subject usergrid git commit: Ignored two tests that are long longer valid tools test since the inclusion of a read repair. They are now part of the service tests.
Date Thu, 12 Nov 2015 20:04:54 GMT
Repository: usergrid
Updated Branches:
  refs/heads/readRepairForIndexValues 91b5ab232 -> a874aa901


Ignored two tests that are long longer valid tools test since the inclusion of a read repair.
They are now part of the service tests.


Project: http://git-wip-us.apache.org/repos/asf/usergrid/repo
Commit: http://git-wip-us.apache.org/repos/asf/usergrid/commit/a874aa90
Tree: http://git-wip-us.apache.org/repos/asf/usergrid/tree/a874aa90
Diff: http://git-wip-us.apache.org/repos/asf/usergrid/diff/a874aa90

Branch: refs/heads/readRepairForIndexValues
Commit: a874aa901d6c869e580430fe5e947316aa33649a
Parents: 91b5ab2
Author: George Reyes <grey@apache.org>
Authored: Thu Nov 12 12:04:50 2015 -0800
Committer: George Reyes <grey@apache.org>
Committed: Thu Nov 12 12:04:50 2015 -0800

----------------------------------------------------------------------
 .../usergrid/tools/UniqueIndexCleanupTest.java  | 21 ++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/usergrid/blob/a874aa90/stack/tools/src/test/java/org/apache/usergrid/tools/UniqueIndexCleanupTest.java
----------------------------------------------------------------------
diff --git a/stack/tools/src/test/java/org/apache/usergrid/tools/UniqueIndexCleanupTest.java
b/stack/tools/src/test/java/org/apache/usergrid/tools/UniqueIndexCleanupTest.java
index 25dd888..0d921d7 100644
--- a/stack/tools/src/test/java/org/apache/usergrid/tools/UniqueIndexCleanupTest.java
+++ b/stack/tools/src/test/java/org/apache/usergrid/tools/UniqueIndexCleanupTest.java
@@ -170,7 +170,9 @@ public class UniqueIndexCleanupTest {
     //For this test you need to insert a dummy key with a dummy column that leads to nowhere
     //then run the unique index cleanup.
     //checks for bug when only column doesn't exist make sure to delete the row as well.
-    @Test
+
+    //due to the read repair this is no longer a valid test of hte unique index cleanup
+    @Ignore
     public void testRepairOfSingleEntity() throws Exception{
         String rand = RandomStringUtils.randomAlphanumeric( 10 );
 
@@ -210,15 +212,16 @@ public class UniqueIndexCleanupTest {
 
         //verify that there is no corresponding entity with the uuid or alias provided
         //verify it returns null.
-        assertNull(entityManager.get( testEntityUUID ));
+        //assertNull(entityManager.get( testEntityUUID ));
 
         //verify that we cannot recreate the entity due to duplicate unique property exception
+        //The Get above should have repaired the entity allowing it run
         Entity entityToBeCorrupted = null;
         try {
             entityToBeCorrupted = entityManager.create( collectionName, userInfo );
-            fail();
+            //fail();
         }catch(DuplicateUniquePropertyExistsException dup){
-
+            fail();
         }
         catch(Exception e){
             fail("shouldn't throw something else i think");
@@ -226,10 +229,10 @@ public class UniqueIndexCleanupTest {
 
 
         //run the cleanup
-        UniqueIndexCleanup uniqueIndexCleanup = new UniqueIndexCleanup();
-        uniqueIndexCleanup.startTool( new String[] {
-                "-host", "localhost:"+ ServiceITSuite.cassandraResource.getRpcPort()
-        }, false );
+//        UniqueIndexCleanup uniqueIndexCleanup = new UniqueIndexCleanup();
+//        uniqueIndexCleanup.startTool( new String[] {
+//                "-host", "localhost:"+ ServiceITSuite.cassandraResource.getRpcPort()
+//        }, false );
 
 
         entityToBeCorrupted = entityManager.create( collectionName,userInfo );
@@ -242,7 +245,9 @@ public class UniqueIndexCleanupTest {
     //For this test you need to insert a dummy key with a dummy column that leads to nowhere
     //then run the unique index cleanup.
     //checks for bug when only column doesn't exist make sure to delete the row as well.
+   // Due to the read repair this is no longer a valid test of unique index cleanup.
     @Test
+    @Ignore
     public void testRepairOfMultipleEntities() throws Exception{
         String rand = RandomStringUtils.randomAlphanumeric( 10 );
 


Mime
View raw message