whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sam Ruby <ru...@apache.org>
Subject [whimsy.git] [1/3] Commit 3c6c5de: [WHIMSY-43] :fire: remove changes record
Date Thu, 28 Jan 2016 14:22:48 GMT
Commit 3c6c5de2583b1a0392914a7fe91a905631181742:
    [WHIMSY-43] :fire: remove changes record
    See also: http://s.apache.org/Tgk


Branch: refs/heads/master
Author: Brett Porter <brett.porter@safetyculture.io>
Committer: Brett Porter <brett.porter@safetyculture.io>
Pusher: rubys <rubys@apache.org>

------------------------------------------------------------
www/roster/js/app._js                                        |  -
www/roster/js/services._js                                   |  ----------
www/roster/main.rb                                           | + --------
www/roster/partials/committee._html                          |  --------
------------------------------------------------------------
45 changes: 2 additions, 43 deletions.
------------------------------------------------------------


diff --git a/www/roster/js/app._js b/www/roster/js/app._js
index 1d0431e..a9fdb11 100644
--- a/www/roster/js/app._js
+++ b/www/roster/js/app._js
@@ -114,7 +114,6 @@ module Angular::AsfRoster
 
     watch @pmcs[@name] do |value|
       @pmc = value || {memberUid: []}
-      @changes = Changes.find(@pmc.display_name)
     end
   end
 
diff --git a/www/roster/js/services._js b/www/roster/js/services._js
index 36831be..b90d43f 100644
--- a/www/roster/js/services._js
+++ b/www/roster/js/services._js
@@ -455,23 +455,4 @@ module Angular::AsfRosterServices
     end
   end
 
-  class Changes
-    @@list = Roster::CHANGES
-
-    def self.find(name)
-      @@list[name] ||= {} if name
-
-      unless @@fetched and (Date.new().getTime()-@@fetched) < 300_000
-        @@fetched = Date.new().getTime()
-        $http.get('json/changes').success do |result|
-          for pmc in result
-            @@list[pmc] ||= {}
-            angular.copy result[pmc], @@list[pmc]
-          end
-        end
-      end
-
-      return @@list[name]
-    end
-  end
 end
diff --git a/www/roster/main.rb b/www/roster/main.rb
index 8165a27..1c82b68 100755
--- a/www/roster/main.rb
+++ b/www/roster/main.rb
@@ -151,22 +151,9 @@
   end
 end
 
+# Deprecated: changes record is not regularly updated
 get '/json/changes' do
-  scripts = ASF::SVN['private/foundation/board/scripts']
-  record = File.read("#{scripts}/pmc-changes-record.txt")
-
-  changes = {}
-
-  ASF::Committee.load_committee_info.each do |pmc| 
-    status = record[/^#{pmc.display_name} ((matches|differs).*?\n)(\w|\Z)/m, 1]
-    changes[pmc.display_name] = {
-      established: record[/^#{pmc.display_name} (established \d+-\d+-\d+)/, 1],
-      status: status && status[/^\w.*/],
-      detail: status && status.scan(/^\t.*/).map(&:strip)
-    }
-  end
-
-  _json { _! changes }
+  _json { }
 end
 
 post '/json/:file' do
diff --git a/www/roster/partials/committee._html b/www/roster/partials/committee._html
index 35eb66e..6b3a99b 100644
--- a/www/roster/partials/committee._html
+++ b/www/roster/partials/committee._html
@@ -2,7 +2,6 @@ _h1 do
   _a '{{pmc.display_name}}', href: '{{pmc.site_link}}'
   _span.note.not_found '(Not in LDAP)', 
      ng_if: 'ldap.ready && pmc.cn && pmc.memberUid.length == 0'
-  _small '{{changes.established}}'
 end
 
 _p '{{pmc.site_description}}'
@@ -68,10 +67,3 @@ _section ng_if: 'pmc.report' do
   end
 end
 
-_section ng_if: 'changes.status' do
-  _h2 'Change Audit'
-  _h4 '{{ changes.status }}'
-  _ul ng_if: 'changes.detail.length > 0' do
-    _li '{{line}}', ng_repeat: 'line in changes.detail'
-  end
-end

Mime
View raw message