whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: only emit warning if chair is not found
Date Tue, 19 Apr 2016 12:32:16 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/whimsy.git

The following commit(s) were added to refs/heads/master by this push:
       new  c2064e4   only emit warning if chair is not found
c2064e4 is described below

commit c2064e4dfafa0fe8779f9e414c0d1c12daac5747
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Tue Apr 19 08:31:59 2016 -0400

    only emit warning if chair is not found
---
 lib/whimsy/asf/agenda/special.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/whimsy/asf/agenda/special.rb b/lib/whimsy/asf/agenda/special.rb
index 72061a1..376e873 100644
--- a/lib/whimsy/asf/agenda/special.rb
+++ b/lib/whimsy/asf/agenda/special.rb
@@ -90,14 +90,14 @@ class ASF::Board::Agenda
 
             if chairname =~ /\s\(([-.\w]+)\)$/
               # if chair's id is present in parens, use that value
-              attrs['chair'] = $1
+              attrs['chair'] = $1 unless $1.empty?
             else
               # match chair's name against people in the committee
               chair = people.find {|person| person.first == chairname}
               attrs['chair'] = (chair ? chair.last : nil)
             end
 
-            unless chair and chair.last
+            unless attrs['chair']
               attrs['warnings'] ||= ['Chair not found in resolution'] 
             end
           else

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message