whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: Dir.chdir is a no-no in a long running process
Date Fri, 08 Jul 2016 17:42:25 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/whimsy.git

The following commit(s) were added to refs/heads/master by this push:
       new  6650168   Dir.chdir is a no-no in a long running process
6650168 is described below

commit 6650168f4a00f58551dcca800eed5531c25f4269
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Fri Jul 8 13:42:01 2016 -0400

    Dir.chdir is a no-no in a long running process
---
 www/board/agenda/views/actions/posted-reports.json.rb | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/www/board/agenda/views/actions/posted-reports.json.rb b/www/board/agenda/views/actions/posted-reports.json.rb
index bdd6025..5743429 100755
--- a/www/board/agenda/views/actions/posted-reports.json.rb
+++ b/www/board/agenda/views/actions/posted-reports.json.rb
@@ -32,9 +32,8 @@ archive.each do |email|
 end
 
 # Get a list of missing board reports
-Dir.chdir ASF::SVN['private/foundation/board']
-agenda = Dir['board_agenda_*.txt'].sort.last.untaint
-parsed = ASF::Board::Agenda.parse(IO.read(agenda), true)
+agendas = Dir["#{ASF::SVN['private/foundation/board']}/board_agenda_*.txt"]
+parsed = ASF::Board::Agenda.parse(IO.read(agendas.sort.last.untaint), true)
 missing = parsed.select {|item| item['missing']}.
   map {|item| item['title'].downcase}
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message