whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: add ppmc actions
Date Wed, 18 Jan 2017 15:17:25 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/whimsy.git

The following commit(s) were added to refs/heads/master by this push:
       new  5217d2a   add ppmc actions
5217d2a is described below

commit 5217d2acb36a6fb66e87183574ab72f65a4c3737
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Wed Jan 18 10:17:09 2017 -0500

    add ppmc actions
---
 www/roster/models/ppmc.rb           | 1 -
 www/roster/views/ppmc/main.js.rb    | 2 +-
 www/roster/views/ppmc/members.js.rb | 4 ++--
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/www/roster/models/ppmc.rb b/www/roster/models/ppmc.rb
index 417c6e4..c2fb9f8 100644
--- a/www/roster/models/ppmc.rb
+++ b/www/roster/models/ppmc.rb
@@ -25,7 +25,6 @@ class PPMC
         [person.id, {name: person.public_name, member: person.asf_member?}]
       }.to_h,
       mail: Hash[lists.sort],
-      schedule: ppmc.reporting,
     }
 
     response
diff --git a/www/roster/views/ppmc/main.js.rb b/www/roster/views/ppmc/main.js.rb
index adb6c80..cca24b1 100644
--- a/www/roster/views/ppmc/main.js.rb
+++ b/www/roster/views/ppmc/main.js.rb
@@ -52,7 +52,7 @@ class PPMC < React
     end
 
     # hidden form
-    _PPMCConfirm pmc: @ppmc.id, update: self.update if auth
+    _PPMCConfirm ppmc: @ppmc.id, update: self.update if auth
   end
 
   # capture ppmc on initial load
diff --git a/www/roster/views/ppmc/members.js.rb b/www/roster/views/ppmc/members.js.rb
index 13b7c9e..f519798 100644
--- a/www/roster/views/ppmc/members.js.rb
+++ b/www/roster/views/ppmc/members.js.rb
@@ -92,7 +92,7 @@ class PPMCMember < React
         _td @@person.name
       end
         
-      _td do
+      _td data_id: @@person.id do
         if @state == :open
           if @@person.status == 'pending'
             _button.btn.btn_primary 'Add to the PPMC',
@@ -123,7 +123,7 @@ class PPMCMember < React
 
   # automatically open pending entries
   def componentWillReceiveProps(newprops)
-    @state = :closed if @ppmc and newprops.ppmc.id != @ppmc.id
+    @state = :closed if newprops.person.id != self.props.person.id
     @state = :open if @@person.status == 'pending'
   end
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message