whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: make entire bar clickable in the comment and shepard pages
Date Thu, 18 May 2017 01:16:43 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git

The following commit(s) were added to refs/heads/master by this push:
       new  8a074f2   make entire bar clickable in the comment and shepard pages
8a074f2 is described below

commit 8a074f2b60de4249d74e4c28b0d80b549dfc2ae1
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Wed May 17 21:16:13 2017 -0400

    make entire bar clickable in the comment and shepard pages
---
 www/board/agenda/public/stylesheets/app.css | 5 +++++
 www/board/agenda/views/pages/comments.js.rb | 4 +---
 www/board/agenda/views/pages/shepherd.js.rb | 8 ++------
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/www/board/agenda/public/stylesheets/app.css b/www/board/agenda/public/stylesheets/app.css
index 1a92f71..1c7cedc 100644
--- a/www/board/agenda/public/stylesheets/app.css
+++ b/www/board/agenda/public/stylesheets/app.css
@@ -64,6 +64,11 @@ h3 span.owner {
   font-size: medium;
 }
 
+/* block links */
+a.h3, a.h4 {
+  display: block;
+}
+
 /* center the table */
 table {
   margin-left: auto;
diff --git a/www/board/agenda/views/pages/comments.js.rb b/www/board/agenda/views/pages/comments.js.rb
index ba8b6fd..a7d8b26 100644
--- a/www/board/agenda/views/pages/comments.js.rb
+++ b/www/board/agenda/views/pages/comments.js.rb
@@ -45,9 +45,7 @@ class Comments < React
         found = true
 
         _section do
-          _h4 class: item.color do 
-            _Link text: item.title, href: item.href
-          end
+          _Link text: item.title, href: item.href, class: "h4 #{item.color}"
 
           visible.each do |comment|
             _pre.comment comment
diff --git a/www/board/agenda/views/pages/shepherd.js.rb b/www/board/agenda/views/pages/shepherd.js.rb
index b66f4a5..266539f 100644
--- a/www/board/agenda/views/pages/shepherd.js.rb
+++ b/www/board/agenda/views/pages/shepherd.js.rb
@@ -19,14 +19,10 @@ class Shepherd < React
     end
 
     # list agenda items associated with this shepherd
-    first = true
     Agenda.index.each do |item|
       if item.shepherd and item.shepherd.downcase().start_with? shepherd
-        _h3 class: item.color do
-          _Link text: item.title, href: "shepherd/queue/#{item.href}",
-            class: ('default' if first)
-          first = false
-        end
+        _Link text: item.title, href: "shepherd/queue/#{item.href}",
+          class: "h3 #{item.color}"
 
         _AdditionalInfo item: item, prefix: true
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message