whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Check for committers without ICLAs
Date Thu, 12 Jul 2018 14:36:09 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 38179d3  Check for committers without ICLAs
38179d3 is described below

commit 38179d3bd8c66d122897f8bc0a7528e37b421c3f
Author: Sebb <sebb@apache.org>
AuthorDate: Thu Jul 12 15:36:08 2018 +0100

    Check for committers without ICLAs
---
 www/secretary/icla-lint.cgi | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/www/secretary/icla-lint.cgi b/www/secretary/icla-lint.cgi
index 1a795c8..5e10de2 100755
--- a/www/secretary/icla-lint.cgi
+++ b/www/secretary/icla-lint.cgi
@@ -7,6 +7,8 @@ require 'ruby2js/filter/functions'
 require 'whimsy/asf'
 
 ldap = ASF::Person.listids
+committers = ASF::Group['committers'].memberids # to check for missing ICLAs
+
 errors = 0
 
 _html do
@@ -22,7 +24,9 @@ _html do
 
   _h2_ 'LDAP Status'
   _div do 
-    _label "#{ldap.length} entries found."
+    _label "#{ldap.length} People entries found."
+    _br
+    _label "#{committers.length} committers found."
    end
 
   _h2_ 'Error Status'
@@ -144,6 +148,9 @@ _html do
         if not missing.empty?
           issue, note = 'error', "missing icla: #{missing.first.inspect}"
         end
+        if id != 'notinavail'
+          committers.delete(id) # drop committers that have ICLAs 
+        end
       elsif comment =~ /^Treasurer;/ or comment =~ /^President;/
 
       elsif comment == 'Signed CLA'
@@ -189,6 +196,30 @@ _html do
     end
   end
 
+  # drop entries which have nologin set
+  committers.reject! do |id|
+    ASF::Person[id].nologin?
+  end
+
+  _h2 'Committers without an ICLA recorded (excluding ones with nologin? true)'
+
+  if committers.size > 0
+    _table do
+      _tr do
+        _th 'id'
+      end
+      committers.each do |id|
+        _tr do
+          _td do
+            _a id, href: '/roster/committer/' + id
+          end
+        end
+      end
+    end
+  else
+    _ 'All committers have ICLAs'
+  end
+
   # select entries with count != 1  
   seen.select! {|k,v| v != 1}
   if seen.size > 0


Mime
View raw message