whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Fix up column detector
Date Sat, 28 Jul 2018 14:18:46 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 60eca41  Fix up column detector
60eca41 is described below

commit 60eca4182874a2061b8bea4dd483b40791af0f7f
Author: Sebb <sebb@apache.org>
AuthorDate: Sat Jul 28 15:18:45 2018 +0100

    Fix up column detector
---
 www/secretary/public-names.cgi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/secretary/public-names.cgi b/www/secretary/public-names.cgi
index ee4ee24..d8cb58d 100755
--- a/www/secretary/public-names.cgi
+++ b/www/secretary/public-names.cgi
@@ -158,6 +158,7 @@ _html do
   end
 
   _table do
+    # column number and order MUST agree with columnNames variable below
     _tr do
       _th "availid"
       _th "ICLA file"
@@ -369,7 +370,8 @@ _html do
     # capture modifications when button is pressed
     document.querySelector('input[type=submit]').addEventListener(:click) do
       updates = {}
-      columnNames = %w(id legal_name public_name ldap)
+      # Must agree with number of columns in the main table above
+      columnNames = %w(id icla_file legal_name public_name ldap)
 
       Array(document.querySelectorAll('td.modified')).each do |td|
         id = td.parentNode.firstElementChild.textContent.strip()


Mime
View raw message