whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Standardise order: id, githubUsername, publicname
Date Wed, 12 Dec 2018 19:52:13 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new aad87c6  Standardise order: id, githubUsername, publicname
aad87c6 is described below

commit aad87c6baf1ccfdb8b33e8a557dd5b4bfbb4bb30
Author: Sebb <sebb@apache.org>
AuthorDate: Wed Dec 12 19:52:04 2018 +0000

    Standardise order: id, githubUsername, publicname
    
    All the other pages use the above order
---
 www/roster/views/pmc/pmc.js.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/roster/views/pmc/pmc.js.rb b/www/roster/views/pmc/pmc.js.rb
index 822d6fe..d4774b0 100644
--- a/www/roster/views/pmc/pmc.js.rb
+++ b/www/roster/views/pmc/pmc.js.rb
@@ -16,8 +16,8 @@ class PMCMembers < Vue
         _tr do
           _th if @@auth
           _th 'id', data_sort: 'string'
-          _th.sorting_asc 'public name', data_sort: 'string-ins'
           _th 'githubUsername', data_sort: 'string'
+          _th.sorting_asc 'public name', data_sort: 'string-ins'
           _th 'starting date', data_sort: 'string'
           _th 'status - click cell for actions', data_sort: 'string'
         end
@@ -144,16 +144,16 @@ class PMCMember < Vue
         _td { _b { _a @@person.id, href: "committer/#{@@person.id}" }
               _a ' (*)', href: "committee/#{@@committee.id}#crosscheck" if @@person.notSubbed
and @@committee.analysePrivateSubs
             }
+        _td @@person.githubUsername
         _td { _b @@person.name }
       else
         _td { _a @@person.id, href: "committer/#{@@person.id}"
               _a ' (*)', href: "committee/#{@@committee.id}#crosscheck" if @@person.notSubbed
and @@committee.analysePrivateSubs
             }
+        _td @@person.githubUsername
         _td @@person.name
       end
 
-      _td @@person.githubUsername
-
       _td @@person.date
 
       if @state == :open


Mime
View raw message