whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Tweaks
Date Thu, 10 Jan 2019 21:41:14 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 6661e4f  Tweaks
6661e4f is described below

commit 6661e4f8ad7802283c780f4fb1c3da57b8aca669
Author: Sebb <sebb@apache.org>
AuthorDate: Thu Jan 10 21:41:13 2019 +0000

    Tweaks
---
 www/roster/models/nonpmc.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/roster/models/nonpmc.rb b/www/roster/models/nonpmc.rb
index f707518..27a3f1b 100644
--- a/www/roster/models/nonpmc.rb
+++ b/www/roster/models/nonpmc.rb
@@ -6,7 +6,6 @@ class NonPMC
     return unless cttee.nonpmc?
     members = cttee.owners
     committers = cttee.committers
-#    return if members.empty? and committers.empty?
 
     ASF::Committee.load_committee_info
     # We'll be needing the mail data later
@@ -30,6 +29,7 @@ class NonPMC
     unMatchedSubs = [] # unknown private@ subscribers
     unMatchedSecSubs = [] # unknown security@ subscribers
     currentUser = ASF::Person.find(env.user)
+    # TODO does not make sense for non-PMCs - remove the code
     analysePrivateSubs = false # whether to show missing private@ subscriptions
     if cttee.roster.include? env.user or currentUser.asf_member?
       require 'whimsy/asf/mlist'
@@ -53,12 +53,12 @@ class NonPMC
     end
 
     roster = cttee.roster.dup
-    roster.each {|key, info| info[:role] = 'PMC member'}
+    roster.each {|key, info| info[:role] = 'Committee member'}
 
     members.each do |person|
       roster[person.id] ||= {
         name: person.public_name, 
-        role: 'PMC member'
+        role: 'Committee member'
       }
       if analysePrivateSubs
         allMail = person.all_mail.map{|m| m.downcase}


Mime
View raw message