whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Disable LDAP checks for now
Date Thu, 10 Jan 2019 22:33:48 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new e71b419  Disable LDAP checks for now
e71b419 is described below

commit e71b41937598d741beba989ad7a760291d0418f6
Author: Sebb <sebb@apache.org>
AuthorDate: Thu Jan 10 22:33:46 2019 +0000

    Disable LDAP checks for now
---
 www/roster/views/nonpmc/nonpmc.js.rb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/www/roster/views/nonpmc/nonpmc.js.rb b/www/roster/views/nonpmc/nonpmc.js.rb
index 8141607..20760c4 100644
--- a/www/roster/views/nonpmc/nonpmc.js.rb
+++ b/www/roster/views/nonpmc/nonpmc.js.rb
@@ -11,6 +11,7 @@ class NonPMCMembers < Vue
   def render
     _h2.pmc! 'Committee (' + roster.length + ')'
     _p 'Click on column name to sort'
+    _p '** N.B. The status column does not currently show LDAP discrepancies. This is because
the non-PMC committees do not use LDAP in the same way currently **'
     _table.table.table_hover do
       _thead do
         _tr do
@@ -140,10 +141,11 @@ class NonPMCMember < Vue
         end
       elsif not @@person.date
         _td.issue.clickable 'not in committee-info.txt', onClick: self.select
-      elsif not @@person.ldap
-        _td.issue.clickable 'not in LDAP', onClick: self.select
-      elsif not @@nonpmc.committers.include? @@person.id
-        _td.issue.clickable 'not in committer list', onClick: self.select
+        # TODO the LDAP groups are not set up in the usual way so this is not all that useful
at present
+#      elsif not @@person.ldap
+#        _td.issue.clickable 'not in LDAP', onClick: self.select
+#      elsif not @@nonpmc.committers.include? @@person.id
+#        _td.issue.clickable 'not in committer list', onClick: self.select
       elsif @@person.id == @@nonpmc.chair
         _td.chair.clickable 'chair', onClick: self.select
       else


Mime
View raw message