whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: update API documention for pmc_chairs and members.
Date Wed, 22 May 2019 19:25:41 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 1b430e4  update API documention for pmc_chairs and members.
1b430e4 is described below

commit 1b430e4d9d4c1c2a759406cb965d85fd7c624971
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Wed May 22 14:49:31 2019 -0400

    update API documention for pmc_chairs and members.
    
    https://whimsy.apache.org/docs/api/
---
 lib/whimsy/asf/ldap.rb   | 1 +
 lib/whimsy/asf/person.rb | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index 81057ac..b455a91 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -390,6 +390,7 @@ module ASF
 
   # Obtain a list of PMC chairs from LDAP 
   # <tt>cn=pmc-chairs,ou=groups,ou=services,dc=apache,dc=org</tt>
+  # Note: this list may include non-PMC VPs.
   def self.pmc_chairs
     weakref(:pmc_chairs) {Service.find('pmc-chairs').members}
   end
diff --git a/lib/whimsy/asf/person.rb b/lib/whimsy/asf/person.rb
index b6378c9..0203c86 100644
--- a/lib/whimsy/asf/person.rb
+++ b/lib/whimsy/asf/person.rb
@@ -136,7 +136,8 @@ module ASF
     end
 
     # Returns <tt>true</tt> if this person is listed as an ASF member in
-    # _either_ LDAP or <tt>members.txt</tt>.
+    # _either_ LDAP or <tt>members.txt</tt>.  Note: LDAP includes
+    # infrastructure staff members that may not be ASF Members.
     def asf_member?
       ASF::Member.status[name] or ASF.members.include? self
     end


Mime
View raw message