whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From curc...@apache.org
Subject [whimsy] branch master updated: Fix spacing for controls without icon addons
Date Sun, 26 May 2019 14:19:17 GMT
This is an automated email from the ASF dual-hosted git repository.

curcuru pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new c145e55  Fix spacing for controls without icon addons
c145e55 is described below

commit c145e5539a974b26862b9cb885156f5da5cffc60
Author: Shane Curcuru <asf@shanecurcuru.org>
AuthorDate: Sun May 26 10:19:09 2019 -0400

    Fix spacing for controls without icon addons
---
 lib/whimsy/asf/forms.rb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/whimsy/asf/forms.rb b/lib/whimsy/asf/forms.rb
index 2889417..04deaaa 100644
--- a/lib/whimsy/asf/forms.rb
+++ b/lib/whimsy/asf/forms.rb
@@ -35,6 +35,10 @@ class Wunderbar::HtmlMarkup
       _span.input_group_addon do
         _span.glyphicon class: "#{args[:icon]}", aria_label: "#{args[:iconlabel]}"
       end
+    elsif ['radio', 'checkbox'].include?(args[:type])
+      # No-op: do not include blank addon for these controls
+    else
+      _span.input_group_addon # HACK: include blank addon to ensure consistent sizing
     end
   end
 


Mime
View raw message