whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Skip tests that don't yet have public test data
Date Mon, 27 May 2019 22:07:34 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new d8f0388  Skip tests that don't yet have public test data
d8f0388 is described below

commit d8f038855f2cad261107270fdbae1c9feb80a867
Author: Sebb <sebb@apache.org>
AuthorDate: Mon May 27 23:07:30 2019 +0100

    Skip tests that don't yet have public test data
---
 lib/spec/lib/mail/mail_spec.rb  |  8 ++++----
 lib/spec/lib/mail/mlist_spec.rb | 14 +++++++-------
 lib/spec/spec_helper.rb         |  3 +++
 3 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/lib/spec/lib/mail/mail_spec.rb b/lib/spec/lib/mail/mail_spec.rb
index febd1dd..a98b29f 100644
--- a/lib/spec/lib/mail/mail_spec.rb
+++ b/lib/spec/lib/mail/mail_spec.rb
@@ -27,10 +27,10 @@ describe ASF::Mail do
 
   describe '.cansub(member, pmc_chair, ldap_pmcs)' do
     lists = ASF::Mail.cansub(false, false, nil)
-    it 'should return public lists only' do
+    it 'should return public lists only', :skip => TEST_DATA do
       whitelist = ['infra-users', 'jobs', 'site-dev', 'committers-cvs', 'site-cvs', 'concom',
'party']
       board = ['board', 'board-commits', 'board-chat']
-      expect(lists.length).to be >= 1000
+      expect(lists.length).to be >= 1000 
       expect(lists).not_to include('private')
       expect(lists).not_to include('security')
       expect(lists).to include(*whitelist)
@@ -40,7 +40,7 @@ describe ASF::Mail do
       mylists = ASF::Mail.cansub(false, false, []) - lists
       expect(mylists.length).to be(0)
     end
-    it 'should return private PMC lists' do
+    it 'should return private PMC lists', :skip => TEST_DATA do
       mylists = ASF::Mail.cansub(false, false, ['ant','whimsical']) - lists
       expect(mylists.length).to be(2)
       expect(mylists).to include('ant-private','whimsical-private')
@@ -49,7 +49,7 @@ describe ASF::Mail do
       mylists = ASF::Mail.cansub(false, false, ['xxxant','xxxwhimsical']) - lists
       expect(mylists.length).to be(0)
     end
-    it 'should return private PPMC lists' do
+    it 'should return private PPMC lists', :skip => TEST_DATA do
       podnames = ASF::Podling.current.map(&:name)
       mylists = ASF::Mail.cansub(false, false, podnames) - lists
       expect(mylists.length).to be_between(podnames.length-2, podnames.length).inclusive
# mailing list may not be set up yet
diff --git a/lib/spec/lib/mail/mlist_spec.rb b/lib/spec/lib/mail/mlist_spec.rb
index 7a39e8c..8650b6c 100644
--- a/lib/spec/lib/mail/mlist_spec.rb
+++ b/lib/spec/lib/mail/mlist_spec.rb
@@ -7,7 +7,7 @@ require 'whimsy/asf/mlist' # not loaded by default
 describe ASF::MLIST do
 
   describe "ASF::MLIST.members_subscribers" do
-    it "should return an array of members@ subscribers followed by the file update time"
do
+    it "should return an array of members@ subscribers followed by the file update time",
:skip => TEST_DATA do
       res = ASF::MLIST.members_subscribers()
       expect(res.class).to eq(Array)
       expect(res.length).to eq(2)
@@ -19,7 +19,7 @@ describe ASF::MLIST do
   end
 
   describe "ASF::MLIST.list_archivers" do
-    it "should return array of form [dom, list, [[archiver, type, alias|direct],...]" do
+    it "should return array of form [dom, list, [[archiver, type, alias|direct],...]", :skip
=> TEST_DATA do
       ASF::MLIST.list_archivers do |res|
         expect(res.class).to eq(Array)
         expect(res.length).to eq(3)
@@ -35,7 +35,7 @@ describe ASF::MLIST do
   end
 
   describe "ASF::MLIST.moderates(user_emails, response)" do
-    it "should not find any entries for invalid emails" do
+    it "should not find any entries for invalid emails", :skip => TEST_DATA do
       user_emails=['user@localhost', 'user@domain.invalid']
       res = ASF::MLIST.moderates(user_emails)
       expect(res.length).to eq(2)
@@ -43,7 +43,7 @@ describe ASF::MLIST do
       expect(mods.length).to eq(0)
     end
 
-    it "should find some entries for mod-private@gsuite.cloud.apache.org" do
+    it "should find some entries for mod-private@gsuite.cloud.apache.org", :skip => TEST_DATA
do
       user_emails=['mod-private@gsuite.cloud.apache.org']
       res = ASF::MLIST.moderates(user_emails)
       expect(res.length).to eq(2)
@@ -53,7 +53,7 @@ describe ASF::MLIST do
   end
 
   describe "ASF::MLIST.subscriptions(user_emails, response)" do
-    it "should not find any entries for invalid emails" do
+    it "should not find any entries for invalid emails", :skip => TEST_DATA do
       user_emails=['user@localhost', 'user@domain.invalid']
       res = ASF::MLIST.subscriptions(user_emails)
       expect(res.length).to eq(2)
@@ -62,7 +62,7 @@ describe ASF::MLIST do
     end
   end
 
-  it "should find lots of entries for archiver@mbox-vm.apache.org" do
+  it "should find lots of entries for archiver@mbox-vm.apache.org", :skip => TEST_DATA
do
     user_emails=['archiver@mbox-vm.apache.org']
     res = ASF::MLIST.subscriptions(user_emails)
     expect(res.length).to eq(2)
@@ -71,7 +71,7 @@ describe ASF::MLIST do
   end
 
   describe "ASF::MLIST.each_list" do
-    it "should return an array of form [[dom, list],...]" do
+    it "should return an array of form [[dom, list],...]", :skip => TEST_DATA do
       ASF::MLIST.each_list do |res|
         expect(res.class).to eq(Array)
         expect(res.length).to eq(2)
diff --git a/lib/spec/spec_helper.rb b/lib/spec/spec_helper.rb
index 0996a03..0f6dcea 100644
--- a/lib/spec/spec_helper.rb
+++ b/lib/spec/spec_helper.rb
@@ -3,7 +3,10 @@ $LOAD_PATH.unshift '/srv/whimsy/lib'
 require 'whimsy/asf'
 # Override with test data if there is no checkout available (allows local use)
 unless ASF::SVN.find('apmail_bin')
+  TEST_DATA = true # Test data does not yet support all tests
   ASF::SVN['apmail_bin'] = File.expand_path('../test/svn/apmail_bin', __dir__)
+else
+  TEST_DATA = false
 end
 
 unless defined?(SPEC_ROOT)


Mime
View raw message