whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Cannot use @apache.org address here
Date Tue, 19 May 2020 13:18:53 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 8d4b967  Cannot use @apache.org address here
8d4b967 is described below

commit 8d4b9679efbcba6230dd2a161be326080e9ea12a
Author: Sebb <sebb@apache.org>
AuthorDate: Tue May 19 14:18:22 2020 +0100

    Cannot use @apache.org address here
---
 www/secretary/workbench/views/actions/icla.json.rb  | 4 ++++
 www/secretary/workbench/views/actions/icla2.json.rb | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/www/secretary/workbench/views/actions/icla.json.rb b/www/secretary/workbench/views/actions/icla.json.rb
index b5ba9ef..15649df 100644
--- a/www/secretary/workbench/views/actions/icla.json.rb
+++ b/www/secretary/workbench/views/actions/icla.json.rb
@@ -31,6 +31,10 @@ else
   _warn "#@filename#{fileext} does not appear to be a valid filename"
 end
 
+if @email.strip.end_with? '@apache.org'
+  _warn "Cannot redirect email to an @apache.org address: #{@email.strip}"
+end
+
 # extract/verify project
 _extract_project
 
diff --git a/www/secretary/workbench/views/actions/icla2.json.rb b/www/secretary/workbench/views/actions/icla2.json.rb
index 1d0a006..48de802 100644
--- a/www/secretary/workbench/views/actions/icla2.json.rb
+++ b/www/secretary/workbench/views/actions/icla2.json.rb
@@ -24,6 +24,10 @@ _personalize_email(env.user)
 
 @filename.untaint if @filename =~ /\A\w[-.\w]*\z/
 
+if @email.strip.end_with? '@apache.org'
+  _warn "Cannot redirect email to an @apache.org address: #{@email.strip}"
+end
+
 if not ASF::ICLAFiles.Dir? @filename
   # Assumes there is a single matching file
   @existing = ASF::ICLAFiles.matchStem(@filename).first


Mime
View raw message