whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Avoid failure if uid has no ICLA
Date Thu, 28 May 2020 11:02:55 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new a6be0b5  Avoid failure if uid has no ICLA
a6be0b5 is described below

commit a6be0b5a20422810df7f3cae3870c12c3b50a67f
Author: Sebb <sebb@apache.org>
AuthorDate: Thu May 28 12:02:41 2020 +0100

    Avoid failure if uid has no ICLA
---
 www/roster/views/actions/fullname.json.rb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/roster/views/actions/fullname.json.rb b/www/roster/views/actions/fullname.json.rb
index 84f7d2e..0a71328 100644
--- a/www/roster/views/actions/fullname.json.rb
+++ b/www/roster/views/actions/fullname.json.rb
@@ -50,17 +50,17 @@ else
   end
 end
 
-# determine commit message
-if person.icla.legal_name != @legalname
+# determine commit message for updating iclas.txt
+if person.icla && person.icla.legal_name != @legalname
   if person.icla.name != @publicname
     message = "Update legal and public name for #{@userid}"
   else
     message = "Update legal name for #{@userid}"
   end
-elsif person.icla.name != @publicname
+elsif person.icla && person.icla.name != @publicname
   message = "Update public name for #{@userid}"
 else
-  message = nil
+  message = nil # don't update iclas.txt
 end
 
 # update iclas.txt


Mime
View raw message