whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: We're not using stderr, so don't capture it
Date Thu, 04 Jun 2020 11:52:06 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 5b8855c  We're not using stderr, so don't capture it
5b8855c is described below

commit 5b8855c203b355ed2d2a7d7b1255c5e3a86af73d
Author: Sebb <sebb@apache.org>
AuthorDate: Thu Jun 4 12:51:50 2020 +0100

    We're not using stderr, so don't capture it
---
 lib/whimsy/asf/svn.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/whimsy/asf/svn.rb b/lib/whimsy/asf/svn.rb
index 1338ea7..ba5170e 100644
--- a/lib/whimsy/asf/svn.rb
+++ b/lib/whimsy/asf/svn.rb
@@ -43,8 +43,9 @@ module ASF
 
           @repos = Hash[Dir[*svn].map { |name| 
             next unless Dir.exist? name.untaint
+            # TODO not sure why chdir is necessary here; it looks like svn info can handle
soft links OK
             Dir.chdir name.untaint do
-              out, _, status = Open3.capture3('svn', 'info')
+              out, status = Open3.capture2('svn', 'info')
               if status.success?
                 [out[/URL: (.*)/,1].sub(/^http:/,'https:'), Dir.pwd.untaint]
               end


Mime
View raw message