whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Simplify debug
Date Tue, 30 Jun 2020 23:28:33 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 2b7ebb9  Simplify debug
2b7ebb9 is described below

commit 2b7ebb9587e95e4f896dfbc0ea255b12e8b4cc57
Author: Sebb <sebb@apache.org>
AuthorDate: Wed Jul 1 00:28:25 2020 +0100

    Simplify debug
---
 lib/spec/lib/svn_wunderbar_spec.rb | 2 +-
 lib/whimsy/asf/svn.rb              | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/spec/lib/svn_wunderbar_spec.rb b/lib/spec/lib/svn_wunderbar_spec.rb
index 20cb24f..ef6faed 100644
--- a/lib/spec/lib/svn_wunderbar_spec.rb
+++ b/lib/spec/lib/svn_wunderbar_spec.rb
@@ -68,7 +68,7 @@ describe "ASF::SVN.svn_" do
     expect(rc).to be(0)
     expect(out['transcript'].class).to equal(Array)
     exp = ["svn", "info", "--non-interactive", "--", "https://svn.apache.org/repos/asf/attic/site/xdocs/projects/_template.xml"]
-    expect(out['transcript'][1]).to eq(exp.inspect)
+    expect(out['transcript'][1]).to eq(exp.join(' '))
   end
   it "svn_('info', 'no file') should fail with E200009" do
     repo = File.join(ASF::SVN.svnurl('attic-xdocs'),'___')
diff --git a/lib/whimsy/asf/svn.rb b/lib/whimsy/asf/svn.rb
index 9c49f0d..d13ddaa 100644
--- a/lib/whimsy/asf/svn.rb
+++ b/lib/whimsy/asf/svn.rb
@@ -445,8 +445,7 @@ module ASF
       _.system ['echo', [cmd,sysopts].inspect] if options[:verbose] # includes auth
 
       if options[:dryrun] # excludes auth
-        # TODO: improve this
-        return _.system ['echo', cmd.inspect]
+        return _.system cmd.insert(0,'echo')
       end
 
       #  N.B. Version 1.3.3 requires separate hashes for JsonBuilder and BuilderClass,


Mime
View raw message