whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Simplify: use existing method
Date Sun, 20 Sep 2020 16:31:13 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 3379935  Simplify: use existing method
3379935 is described below

commit 3379935ef5664433bb4cb392ab140af7beb6f91c
Author: Sebb <sebb@apache.org>
AuthorDate: Sun Sep 20 17:31:02 2020 +0100

    Simplify: use existing method
---
 lib/whimsy/asf/ldap.rb | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index 236aa8c..e6dc4d9 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -571,12 +571,8 @@ module ASF
       # add person to LDAP
       person = ASF::Person.add(attrs)
 
-      # add person to 'new' committers list
-      ASF::LDAP.modify("cn=committers,#@base", 
-        [ASF::Base.mod_add('member', [person.dn])])
-
-      # add person to 'legacy' committers list
-      ASF::Group['committers'].add(person)
+      # add person to committers lists
+      register(person)
 
       # return new person
       person


Mime
View raw message