whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: No reall need to use taint here
Date Sat, 26 Sep 2020 15:44:35 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new fc6e535  No reall need to use taint here
fc6e535 is described below

commit fc6e5350abe524a0020be2aca94e5c2a349ad455
Author: Sebb <sebb@apache.org>
AuthorDate: Sat Sep 26 16:44:26 2020 +0100

    No reall need to use taint here
---
 www/committers/subscribe.cgi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/www/committers/subscribe.cgi b/www/committers/subscribe.cgi
index c709e69..b584e04 100755
--- a/www/committers/subscribe.cgi
+++ b/www/committers/subscribe.cgi
@@ -10,8 +10,6 @@ require 'time'
 require 'tmpdir'
 require 'escape'
 
-$SAFE = 1
-
 FORMAT_NUMBER = 3 # json format number
 
 user = ASF::Person.new($USER)
@@ -214,7 +212,7 @@ _html do
         end
 
         # Each user can only subscribe once to each list in each timeslot
-        fn = "#{$USER}-#{@list}.json".untaint
+        fn = "#{$USER}-#{@list}.json"
 
         vars = {
           version: FORMAT_NUMBER,
@@ -243,7 +241,6 @@ _html do
         rc = 999
 
         Dir.mktmpdir do |tmpdir|
-          tmpdir.untaint
 
           # commit using user's credentials if possible, otherwise use whisysvn
           if not $PASSWORD


Mime
View raw message