whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Don't shadow variables; flag unused vars
Date Sat, 17 Oct 2020 12:30:02 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 321c489  Don't shadow variables; flag unused vars
321c489 is described below

commit 321c489131212268b47f2b08ef31f7878ce5ea34
Author: Sebb <sebb@apache.org>
AuthorDate: Sat Oct 17 13:29:54 2020 +0100

    Don't shadow variables; flag unused vars
---
 www/board/agenda/views/actions/todos.json.rb | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/www/board/agenda/views/actions/todos.json.rb b/www/board/agenda/views/actions/todos.json.rb
index 5619df4..c39eec3 100644
--- a/www/board/agenda/views/actions/todos.json.rb
+++ b/www/board/agenda/views/actions/todos.json.rb
@@ -68,7 +68,7 @@ if (@change || @establish || @terminate) and env.password
     title = 'board resolutions: ' + todos.map {|todo| todo['name']}.join(', ')
   end
 
-  ASF::SVN.update cinfo, title, env, _ do |tmpdir, contents|
+  ASF::SVN.update cinfo, title, env, _ do |_tmpdir, contents|
     unless minutes[:todos][:next_month]
       # update list of reports expected next month
       missing = parsed_agenda.
@@ -90,8 +90,8 @@ if (@change || @establish || @terminate) and env.password
     # add people from establish resolutions
     established = Date.parse(date.gsub('_', '-'))
     Array(@establish).each do |resolution|
-      item = parsed_agenda.find do |item|
-        item['title'] == resolution['title']
+      item = parsed_agenda.find do |it|
+        it['title'] == resolution['title']
       end
 
       contents = ASF::Committee.establish(contents, resolution['display_name'],
@@ -110,11 +110,11 @@ if @establish and env.password
   @establish.each do |resolution|
     pmc = resolution['name']
 
-    item = parsed_agenda.find do |item|
-      item['title'] == resolution['title']
+    item = parsed_agenda.find do |it|
+      it['title'] == resolution['title']
     end
 
-    members = item['people'].map {|id, hash| ASF::Person.find(id)}
+    members = item['people'].map {|id, _hash| ASF::Person.find(id)}
     people = item['people'].map {|id, hash| [id, hash[:name]]}
 
     ASF::LDAP.bind(env.user, env.password) do
@@ -133,7 +133,7 @@ if @establish and env.password
     if charter
       # update ci.yaml
       cinfoy = File.join(ASF::SVN['board'], 'committee-info.yaml')
-      ASF::SVN.update cinfoy, title, env, _ do |tmpdir, contents|
+      ASF::SVN.update cinfoy, title, env, _ do |_tmpdir, contents|
         ASF::Committee.appendtlpmetadata(contents,pmc.downcase,charter)
       end
     end


Mime
View raw message