whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Add display name to retired details
Date Wed, 24 Feb 2021 17:46:29 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new ae3e91b  Add display name to retired details
ae3e91b is described below

commit ae3e91b27b15e0937d0aeea6e493db479c96cbc6
Author: Sebb <sebb@apache.org>
AuthorDate: Wed Feb 24 17:46:21 2021 +0000

    Add display name to retired details
---
 lib/spec/lib/committee_spec.rb | 7 +++++--
 lib/whimsy/asf/committee.rb    | 3 ++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/lib/spec/lib/committee_spec.rb b/lib/spec/lib/committee_spec.rb
index d786fd2..368c671 100644
--- a/lib/spec/lib/committee_spec.rb
+++ b/lib/spec/lib/committee_spec.rb
@@ -108,19 +108,22 @@ describe ASF::Committee do
       para = yaml[:tlps]['httpd']
       expect(para).not_to eql(nil)
       expect(para[:retired]).to eql(yyyymm)
+      expect(para[:name]).to eql('HTTP Server')
     end
     yaml = YAML.safe_load(data, [Symbol])
-    pmc = 'xyzxyz' # must be downcased
+    name = 'XYZXYZ'
+    pmc = ASF::Committee.to_canonical(name)
     it "should not contain XYZXYZ" do
       para = yaml[:tlps][pmc]
       expect(para).to eql(nil)
     end
     it "should now contain XYZXYZ" do
-      data = ASF::Committee.record_termination(data, pmc, yyyymm)
+      data = ASF::Committee.record_termination(data, name, yyyymm)
       yaml = YAML.safe_load(data, [Symbol])
       para = yaml[:tlps][pmc]
       expect(para).not_to eql(nil)
       expect(para[:retired]).to eql(yyyymm)
+      expect(para[:name]).to eql(name)
     end
   end
 end
diff --git a/lib/whimsy/asf/committee.rb b/lib/whimsy/asf/committee.rb
index 54829a5..56cf490 100644
--- a/lib/whimsy/asf/committee.rb
+++ b/lib/whimsy/asf/committee.rb
@@ -289,8 +289,9 @@ module ASF
         key = ASF::Committee.to_canonical(pmc)
         if section[key]
           section[key][:retired] = yyyymm
+          section[key][:name] = pmc
         else
-          section[key] = {retired: yyyymm}
+          section[key] = {retired: yyyymm, name: pmc}
         end
         section.sort.to_h
       end


Mime
View raw message